Enhance identity matrix tests and improve exception handling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance tests for identity matrix creation and invalid dimensions - Added parameterized tests for the `eye` function to verify creation of identity matrices of various sizes, including edge cases (1x1 and 5x5 matrices). - Implemented test for expected exceptions when invalid dimensions (negative and zero values) are provided. - Updated `provideValidEyeData` and `provideInvalidEyeDimensions` methods to supply comprehensive test cases for the identity matrix creation. - Improved assertions to validate the shape of the resulting matrices and confirm correct behavior when exceptions are expected. - Commented out `assertArrayEquals` for future implementation once array comparison logic is determined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
Add parameterized test data and fixes for identity matrix creation:
Introduced static data providers using
Stream<Arguments>for parameterized tests:provideValidEyeData: Validates the creation of identity matrices with various sizes, including edge cases (1x1 and 5x5 matrices).provideInvalidEyeDimensions: Tests for expected exceptions when creating identity matrices with invalid dimensions (negative and zero values).Fixed identified issues in the
eyefunction and improved exception handling in tests.Enhanced assertions to ensure correct matrix shape and behavior when exceptions are encountered.