Remove edgeWeights from convex polygons #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading https://lisyarus.github.io/blog/posts/implementing-a-tiny-cpu-rasterizer-part-2.html, I'm convinced that providing the edge weights like this is incorrect. What the API should do is to provide barycentric coordinates.
This could either require the method to only exist for triangles, some kind of tesselation or the use of [generalized barycentric coordinates](generalized barycentric coordinates).
Since the API is still experimental, I think I would rather remove the method for now and think about it later (it's not like the rasterizer supported this anyway)