Skip to content

Commit

Permalink
Updated CryptoExchange.Net to version 8.4.4 to fix deserialization er…
Browse files Browse the repository at this point in the history
…ror in .net framework
  • Loading branch information
JKorf committed Dec 8, 2024
1 parent a574ae0 commit 340f720
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion Binance.Net/Binance.Net.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="CryptoExchange.Net" Version="8.4.3" />
<PackageReference Include="CryptoExchange.Net" Version="8.4.4" />
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
4 changes: 2 additions & 2 deletions Binance.Net/Objects/Models/BinanceOrderBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public record BinanceOrderBase
/// Original order id
/// </summary>
[JsonPropertyName("origClientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string OriginalClientOrderId { get; set; } = string.Empty;
Expand All @@ -38,7 +38,7 @@ public record BinanceOrderBase
/// The order id as assigned by the client
/// </summary>
[JsonPropertyName("clientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public record BinanceAlgoOrder
/// Client algo id
/// </summary>
[JsonPropertyName("clientAlgoId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientAlgoId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public record BinanceAlgoOrderResult: BinanceResult
/// Order id
/// </summary>
[JsonPropertyName("clientAlgoId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientAlgoId { get; set; } = string.Empty;
Expand Down
2 changes: 1 addition & 1 deletion Binance.Net/Objects/Models/Futures/BinanceFuturesOrder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public record BinanceFuturesOrder
/// The order id as assigned by the client
/// </summary>
[JsonPropertyName("clientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public record BinanceFuturesOrderEditHistory
/// The order id as assigned by the client
/// </summary>
[JsonPropertyName("clientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string? ClientOrderId { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public record BinanceFuturesStreamOrderUpdateData
/// The new client order id
/// </summary>
[JsonPropertyName("c")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public record BinanceFuturesStreamTradeUpdate : BinanceStreamEvent
/// "settlement_autoclose-": settlement order for delisting or delivery
/// </remarks>
[JsonPropertyName("c")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
4 changes: 2 additions & 2 deletions Binance.Net/Objects/Models/Spot/BinanceOrderOcoList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public record BinanceOrderOcoList
/// The client id of the order list
/// </summary>
[JsonPropertyName("listClientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ListClientOrderId { get; set; } = string.Empty;
Expand Down Expand Up @@ -78,7 +78,7 @@ public record BinanceOrderId
/// The client order id
/// </summary>
[JsonPropertyName("clientOrderId")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public record BinanceStreamOrderList: BinanceStreamEvent
/// The client id of the order list
/// </summary>
[JsonPropertyName("C")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ListClientOrderId { get; set; } = string.Empty;
Expand Down Expand Up @@ -82,7 +82,7 @@ public record BinanceStreamOrderId
/// The client order id
/// </summary>
[JsonPropertyName("c")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public record BinanceStreamOrderUpdate: BinanceStreamEvent
/// The new client order id
/// </summary>
[JsonPropertyName("c")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string ClientOrderId { get; set; } = string.Empty;
Expand Down Expand Up @@ -75,7 +75,7 @@ public record BinanceStreamOrderUpdate: BinanceStreamEvent
/// The original client order id
/// </summary>
[JsonPropertyName("C")]
[JsonConverterCtor<ReplaceConverter>(
[JsonConverterCtor(typeof(ReplaceConverter),
$"{BinanceExchange.ClientOrderIdPrefixSpot}->",
$"{BinanceExchange.ClientOrderIdPrefixFutures}->")]
public string? OriginalClientOrderId { get; set; } = string.Empty;
Expand Down

0 comments on commit 340f720

Please sign in to comment.