Fixed reconnection bug for query connections without active subscription

JKorf · Dec 23, 2024 · 34d6568 · 34d6568
1 parent f90e033
commit 34d6568
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/Kraken.Net/Clients/SpotApi/KrakenSocketClientSpotApi.cs b/Kraken.Net/Clients/SpotApi/KrakenSocketClientSpotApi.cs
@@ -57,6 +57,20 @@ internal KrakenSocketClientSpotApi(ILogger logger, KrakenSocketOptions options)
             RateLimiter = KrakenExchange.RateLimiter.SpotSocket;
 
             SetDedicatedConnection(_privateBaseAddress, false);
+
+            RegisterPeriodicQuery(
+                "Ping",
+                TimeSpan.FromSeconds(30),
+                x => new KrakenSpotPingQuery(),
+                (connection, result) =>
+                {
+                    if (result.Error?.Message.Equals("Query timeout") == true)
+                    {
+                        // Ping timeout, reconnect
+                        _logger.LogWarning("[Sckt {SocketId}] Ping response timeout, reconnecting", connection.SocketId);
+                        _ = connection.TriggerReconnectAsync();
+                    }
+                });
         }
         #endregion
 

diff --git a/Kraken.Net/Objects/Options/KrakenSocketOptions.cs b/Kraken.Net/Objects/Options/KrakenSocketOptions.cs
@@ -34,7 +34,6 @@ public KrakenSocketOptions()
         /// </summary>
         public SocketApiOptions SpotOptions { get; private set; } = new SocketApiOptions()
         {
-            SocketNoDataTimeout = TimeSpan.FromSeconds(10)
         };
 
         /// <summary>

diff --git a/Kraken.Net/Objects/Sockets/Queries/KrakenSpotPingQuery.cs b/Kraken.Net/Objects/Sockets/Queries/KrakenSpotPingQuery.cs
@@ -0,0 +1,18 @@
+using CryptoExchange.Net.Objects.Sockets;
+using CryptoExchange.Net.Sockets;
+using Kraken.Net.Objects.Internal;
+using Kraken.Net.Objects.Models.Socket;
+
+namespace Kraken.Net.Objects.Sockets.Queries
+{
+    internal class KrakenSpotPingQuery : Query<KrakenSocketResponseV2<object>>
+    {
+        public override HashSet<string> ListenerIdentifiers { get; set; }
+
+        public KrakenSpotPingQuery() : base(new KrakenSocketRequestV2 { Method = "ping", RequestId = ExchangeHelpers.NextId() }, false)
+        {
+            RequestTimeout = TimeSpan.FromSeconds(5);
+            ListenerIdentifiers = new HashSet<string>() { ((KrakenSocketRequestV2)Request).RequestId.ToString() };
+        }
+    }
+}