Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor loading for deposits and withdrawals #116

Conversation

ViktorOshkalo
Copy link
Contributor

@ViktorOshkalo ViktorOshkalo commented Sep 18, 2024

Issue

  • no full parameters supprort for private/WithdrawStatus and private/DepositStatus endpoints leading to no ability to load more than default 'limit' number of records

Implemented

  • Added a separate methods to load deposit statuses and withdrawal statuses by cursor loading. It is because the returning json has a different json scema so it seems immposible to me to implement that in the existing methods

docs:
https://docs.kraken.com/api/docs/rest-api/get-status-recent-deposits
https://docs.kraken.com/api/docs/rest-api/get-status-recent-withdrawals

@JKorf
Copy link
Owner

JKorf commented Sep 27, 2024

Hi, during development of some shared functionality I also ran into this issue. I had already fixed it in my pending changed which are now available in the latest version, so this PR is no longer necessary. Thanks for the effort either way

@JKorf JKorf closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants