-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override generated reports base directory. #346
Conversation
9cc68c3
to
df8f809
Compare
* [DirectoryProperty] takes into account also content of directory, when snapshotting input. | ||
* As reports generated are always generated in this directory, this prevents task proper caching, | ||
* so this input exists as a workaround for the described problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task caching also snapshots the outputs. If the output has changed, the task is marked as out of date. Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, was confused by https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/InputDirectory.html. Actually reporterOutputDir
could be just annotated with @get:Input
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force updated and removed this property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or not... running tests in IDEA was green, though from command line they fail 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine now
df8f809
to
3c2a68e
Compare
3c2a68e
to
afe25db
Compare
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
0f9b95b
to
ec58992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Jonathan Leitschuh <jonathan.leitschuh@gmail.com>
Closes #321