Configure configurations as resolvable non-consumable #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the default of being consumable exposes them to variant-aware resolution when the project is depended upon from another project. Also configure the configurations as non-visible for similar reasons: those are specific to this project's build and there's no reason to consume them from another project. Fix JLLeitschuh#523
JLLeitschuh
requested changes
Jan 27, 2022
plugin/src/test/kotlin/org/jlleitschuh/gradle/ktlint/KtlintPluginTest.kt
Show resolved
Hide resolved
Co-authored-by: Jonathan Leitschuh <[email protected]>
|
I also added a changelog entry. The branch should be opened to maintainers though, so feel free to directly make changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the default of being consumable exposes them to
variant-aware resolution when the project is depended
upon from another project.
Also configure the configurations as non-visible for
similar reasons: those are specific to this project's
build and there's no reason to consume them from
another project.
Fix #523