Add relative option similar to CLI's --relative #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this in a large multi-module JVM-only project. |
|
@JLLeitschuh just a friendly ping to make sure this PR is not accidentally overseen (I tend to miss/not receive notifications). |
pschichtel
force-pushed
the
feature/relative-paths-in-reports
branch
from
bd89705 to
643f38b
Compare
|
I actually did miss this, could you rebase this PR for me? |
…s --relative option on the CLI
pschichtel
force-pushed
the
feature/relative-paths-in-reports
branch
from
643f38b to
a18bc8d
Compare
|
@JLLeitschuh done |
|
@JLLeitschuh I see the windows check failed, but it doesn't look like that is related to this change. can you confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this gradle plugin in GitLab-CI and currently it always produces absolute paths which leads to broken links in the code quality report.
This PR adds the option
relativeanalog to ktlint's CLI's--relativeoption, which does the same thing: Instead of outputting absolute paths in the report, the reports are made relative to the root project (ktlint make it relative to the workdir).Currently this is only applied to the actual report file output, not the console output to still have clickable file paths in IntelliJ.