add files previously found to have errors to incremental builds #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
complete-incremental
branch
from
86dd902 to
8a12718
Compare
wakingrufus
commented
Jun 5, 2023
| assertThat(task(":$mainSourceSetCheckTaskName")?.outcome).isEqualTo(TaskOutcome.FAILED) | ||
| assertThat(output) | ||
| .contains("Executing incrementally") | ||
| .contains("Initial.kt") |
There was a problem hiding this comment.
previously, Initial would not be listed (and if AnotherFile passed, the whole task would pass)
wakingrufus
force-pushed
the
complete-incremental
branch
from
8a12718 to
a9a3eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add files previously found to have errors to the list of files to check in incremental builds. This will prevent the lint task from passing when errors are still present.
This should solve #491 and #576