Enhancement: Sane, Smooth UX for Document-Based Workflows #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notator components.
… to support new workflows needed in AnnotatorRenderer and modals to effectively navigate all the new data available within a Corpus.
…nnotations by analysis or extract.
…itional custom resolvers (to simplify frontend requests) and a number of new GUI tweaks. <DocumentAnnotator/> is a massive bit of code duplication and is also forcing me to keep a massive (and not great) query in queries.ts. Once this new component is working nicely, I want to pull all of that out.
…ing and working. Needs polish and tuning.
…low for better tracking of resulting data. Added GUI indicators for action-created data on the frontend.
… cross-view display of extract modal - i.e. from clicking Extract in the corpus view.
…ased microservice analyzers AND new task-based analyzer.
… Removed <DocumentAnnotator/> which was *really* similar to CorpusDocumentAnnotator, the primary difference being that it was a kludgy workaround to displaying annotations that weren't linked to a corpus - like from an extract, which was the first time I had annotations that weren't linked to a corpus. Also cleaned up some of the global state handling and created a pretty detailed explanation of the component-level state handler in the annotator, which should, ideally, be refactored to use Apollo state store. This should wait until *after* we have test coverage for the component as I don't want to do that much refactoring without more guardrails.
…couple DB relationships.
…g. annotations vs viewing analyses vs merely viewing the document.
…scaling of the annotations by setting a global scale level and then using useEffect hooks on pages to react to that and dynamically change pdfPageInfo scale property.
…the canvas in its parent container. This meant the absolute positioning of the annotation from left side was drifting slowly. There is probably a way to fix this, but not worth the effort ATM. Looks acceptable. Works fine.
…and interaction. HUGE improvement.
…now-intended use for ALL document-related viewing, editing and data entry.
…ANNOTATOR_DATA_FOR_DOCUMENT_IN_CORPUS query.
…ts, annotations and related data. Also updated query to get doc actions and extracts so it works with documents and extracts that were made public.
…missing (e.g. in mobile view)
…ctionBar/> when use_mobile_layout is true.
…e ways sharing is being handled, because it's NOT great), we need to loosen up restrictions preventing creating multiple copies of the same AnnotationLabel to allow this *so long as they're for different users*
…'t affect reading the text.
…ounding boxes with labels set toshow only on hover. This is quite readable, especially with changes to the selection overlay heights.
…ed. This is dangerous, but it's a superuser power and can be messaged appropriately. More fine-grained sharing will be a big focus of 3.0.0
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<DocumentAnnotator/>is THE component for all document-related interactions- including, ironically, ones not involving a corpus, so that should probably be renamed too(DONE!). It's now much easier to navigate document analyses, extracts and annotations, all from within a single view.Couple items that still need cleanup
Fixes #152, #207, #209, #210