Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file addition problem in xcodeproj #34

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Fix file addition problem in xcodeproj #34

merged 2 commits into from
Apr 25, 2019

Conversation

mrylmz
Copy link
Contributor

@mrylmz mrylmz commented Apr 25, 2019 •
edited by Jeehut
Loading

Fixes #29.

@mrylmz mrylmz requested review from Jeehut and fredpi April 25, 2019 12:59
@Jeehut Jeehut changed the title Fix file addition problem in xcodeproj resolving issue #29 Fix file addition problem in xcodeproj Apr 25, 2019
Jeehut
Jeehut reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please post a PR on XcodeProj and also make sure the tests are passing. Then we can merge.

Package.resolved Show resolved Hide resolved
@Jeehut
Copy link
Contributor

Jeehut commented Apr 25, 2019

Great, thanks! 🎉
Merging.

@Jeehut Jeehut merged commit d0858b6 into stable Apr 25, 2019
@mrylmz mrylmz deleted the work/29-dependency-linkage branch May 2, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeehut Jeehut Jeehut approved these changes

@fredpi fredpi Awaiting requested review from fredpi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linking problems with apps split into modules
2 participants
@mrylmz @Jeehut