Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing CFBundleVersion for dependencies #70

Merged
merged 4 commits into from
Jul 12, 2019
Merged

Fix missing CFBundleVersion for dependencies #70

merged 4 commits into from
Jul 12, 2019

Conversation

mrylmz
Copy link
Contributor

@mrylmz mrylmz commented Jul 10, 2019

Closes #69

@mrylmz mrylmz requested a review from Jeehut July 10, 2019 12:16
@mrylmz mrylmz self-assigned this Jul 10, 2019
@fredpi
Copy link
Contributor

fredpi commented Jul 10, 2019

@mrylmz Would you mind adding a changelog entry? :)

@Jeehut
Copy link
Contributor

Jeehut commented Jul 11, 2019

A test for the new method would be great too, one for the case when there is a CFBundleVersion set and one for when it's not.

@Jeehut Jeehut merged commit 4bfafa8 into stable Jul 12, 2019
@phimage phimage mentioned this pull request Jul 31, 2019
Closed
@tcurdt tcurdt mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredpi fredpi fredpi approved these changes

@Jeehut Jeehut Awaiting requested review from Jeehut

Assignees

@mrylmz mrylmz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CFBundleVersion in Info.plist of frameworks
3 participants
@mrylmz @fredpi @Jeehut