Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globalDisableCountDown: use ng-if instead of ng-hide to avoid DOM update every second #98

Closed
sheymann opened this issue Jun 28, 2015 · 3 comments

Comments

@sheymann
Copy link

Using growlProvider.globalDisableCountDown(true); the HTML markup is still inserted in the DOM:

<button type="button" class="close ng-binding ng-hide" aria-hidden="true" ng-show="showCountDown(message)">
  39
</button>

and the timer is updated every second. As a consequence the DOM is updated every second as well, which hurts performance.

@flippinjoe
Copy link
Collaborator

Definitely agree. Great find. I'll get this one in asap

flaviocysne added a commit to flaviocysne/angular-growl-2 that referenced this issue May 31, 2016
Issue JanStevens#98 : globalDisableCountDown: use ng-if instead of ng-hide to avoid DOM update every second.

Also changed ng-show in growl-title to ng-if
@flaviocysne
Copy link

flaviocysne commented May 31, 2016

This is a minor change to the angular-growl-2 template. You can create your own template, similar to the default one, and change ng-show to ng-if.

I submitted a pull request to change it. Vote for it.

flaviocysne added a commit to flaviocysne/angular-growl-2 that referenced this issue May 31, 2016
All ``ng-show`` attributes changed to ``ng-if``.
flippinjoe added a commit that referenced this issue Sep 14, 2016
Updating template to resolve Issue #98
@blitzmann
Copy link

If I understand correctly, this issue has been resolved by the pull requests, correct? Can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants