Remove fotmob functions
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 67.72% 62.74% -4.98%
==========================================
Files 49 43 -6
Lines 4065 3358 -707
==========================================
- Hits 2753 2107 -646
+ Misses 1312 1251 -61
|
tonyelhabr
commented
Aug 8, 2023
| @@ -411,16 +411,3 @@ | |||
| session <- rvest::session(url = page_url, ua) | |||
| xml2::read_html(session) | |||
| } | |||
|
|
|||
| #' @importFrom httr GET content | |||
There was a problem hiding this comment.
these functions were only used by fotmob functions
tonyelhabr
commented
Aug 8, 2023
| @@ -300,12 +300,12 @@ test_that("fb_team_player_stats() works", { | |||
| Sys.sleep(3) | |||
| test_that("fb_team_match_log_stats() works", { | |||
| testthat::skip_on_cran() | |||
| liv_keeper_log <- fb_team_match_log_stats(team_url= "https://fbref.com/en/squads/822bd0ba/Liverpool-Stats", stat_type= 'keeper', time_pause = 4) | |||
| liv_keeper_log <- fb_team_match_log_stats(team_url= "https://fbref.com/en/squads/822bd0ba/2022-2023/Liverpool-Stats", stat_type= 'keeper', time_pause = 4) | |||
There was a problem hiding this comment.
drive by fix: this was failing, i think because it was looking for 2023/2024 stats
JaseZiv
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fotmob updated their terms of service stating that "the use of automatic services (robots, spiders, indexing etc.) as well as other methods for systematic or regular use is not permitted." While "robots, spiders, etc." doesn't necessarily imply data scraping is off limits, the fotmob CEO has written us something akin to a "cease and desist" notice insisting that we remove our fotmob functions. We're not in a position to counter, so we've decided to comply.