Replace Browserify with Rollup (#332)

JedWatson · Dec 22, 2023 · 5d72c08 · 5d72c08
1 parent b0e093e
commit 5d72c08
Show file tree

Hide file tree

Showing 6 changed files with 605 additions and 1,447 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -21,5 +21,5 @@ run in the v8 version that your local Node.js uses, while classNames is _most_
 often run across a wide variety of browsers and browser versions.
 
 It is recommended to test possible regressions in performance in all major
-browsers. This can be done by running `npm run benchmarks-browserify` in the
-`./benchmarks` directory.
+browsers. This can be done by running `npm run benchmarks-browser` in the
+`./benchmarks` directory, the benchmark will then be served from http://localhost:8080.
diff --git a/benchmarks/benchmarks.html b/benchmarks/benchmarks.html
diff --git a/benchmarks/index.html b/benchmarks/index.html
@@ -0,0 +1,12 @@
+<!doctype html>
+<html lang="en">
+	<head>
+		<meta charset="utf-8">
+		<title>Benchmarks</title>
+	</head>
+	<body>
+		<div id="results"></div>
+		<div id="loader">Wait please&hellip;</div>
+		<script src="runInBrowser.bundle.js"></script>
+	</body>
+</html>
diff --git a/benchmarks/package.json b/benchmarks/package.json
@@ -2,12 +2,17 @@
   "name": "classnames-benchmarks",
   "scripts": {
     "benchmarks": "node ./run.js",
-    "benchmarks-browserify": "browserify ./runInBrowser.js >./runInBrowser.bundle.js"
+    "benchmarks-browser": "rollup --plugin commonjs,json,node-resolve ./runInBrowser.js --file ./runInBrowser.bundle.js --format iife && http-server -o"
   },
   "devDependencies": {
+    "@rollup/plugin-commonjs": "^25.0.7",
+    "@rollup/plugin-json": "^6.1.0",
+    "@rollup/plugin-node-resolve": "^15.2.3",
     "benchmark": "^2.1.4",
-    "browserify": "^17.0.0",
+    "classnames-local": "file:../",
     "classnames-npm": "npm:classnames@*",
-    "classnames-local": "file:../"
+    "http-server": "^14.1.1",
+    "lodash": "^4.17.21",
+    "rollup": "^4.9.1"
   }
 }
diff --git a/benchmarks/runSuite.js b/benchmarks/runSuite.js
@@ -1,7 +1,10 @@
 var benchmark = require('benchmark');
+var _ = require('lodash');
+
+var Suite = benchmark.runInContext({ _ }).Suite;
 
 function runSuite (local, npm, dedupe, npmDedupe, fixture, log) {
-	var suite = new benchmark.Suite();
+	var suite = new Suite();
 
 	suite.add('local#' + fixture.description, function () {
 		local.apply(null, fixture.args);