Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmarks into dedicated NPM workspace #329

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

jonkoops
Copy link
Collaborator

Moves the classnames-benchmarks package into an NPM workspace containing all of it's own dependencies, and creates aliases for the local and last published NPM version in the package, removing the need to provide a relative path, and reducing the need for additional NPM installs.

@jonkoops jonkoops force-pushed the benchmarks-workspace branch from b22967c to 4650eb6 Compare December 22, 2023 12:47
@jonkoops jonkoops merged commit 6caa90e into main Dec 22, 2023
4 checks passed
@jonkoops jonkoops deleted the benchmarks-workspace branch December 22, 2023 13:17
@dcousens
Copy link
Collaborator

LGTM

@KennanChan
Copy link

It seems that this PR causes yarn to warn about "Workspaces can only be enabled in private projects.".

@jonkoops
Copy link
Collaborator Author

It seems that this PR causes yarn to warn about "Workspaces can only be enabled in private projects.".

Don't use Yarn for this project, it has been set up to work with NPM, it's also the only package manager a lockfile is checked in for.

@KennanChan
Copy link

'Classnames' is actually an indirect dependency of my project. I managed to bypass this warning by setting workspaces-experimental false in yarnrc.

@dcousens
Copy link
Collaborator

@jonkoops the package.json is published though?

@jonkoops
Copy link
Collaborator Author

the package.json is published though?

Correct, but workspaces should have no influence on that as far as I know. Not sure what is going on here, will do some research.

@jonkoops
Copy link
Collaborator Author

I am able to reproduce this, seem like this is a bug in Yarn (yarnpkg/yarn#8580) only present if you use v1 of Yarn, which is unfortunately still the default. When updating to the latest version of Yarn, this problem goes away.

@jonkoops
Copy link
Collaborator Author

@KennanChan this should now be fixed by #350 as soon as the release for v2.5.1 goes through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants