Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel runtime #4254

Closed
wants to merge 1 commit into from

Conversation

thomaswelton
Copy link

Fixes #4253
Update @babel/runtime to fix issues with strict mode on the ESM modules imports

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2020

🦋 Changeset detected

Latest commit: a7c96d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a7c96d7:

Sandbox Source
react-codesandboxer-example Configuration

Add changeset
@thomaswelton thomaswelton force-pushed the upgrade-babel-runtime branch from eb9e51f to a7c96d7 Compare October 16, 2020 13:20
@thomaswelton
Copy link
Author

Cypress tests are passing locally. Am unable to trigger a retry on that circleci job

@thomaswelton thomaswelton deleted the upgrade-babel-runtime branch October 27, 2020 15:09
@ebonow
Copy link
Collaborator

ebonow commented Jan 29, 2021

If you would kindly create another PR, I can have this added as a part of the discussion for the next milestone release.

@thomaswelton thomaswelton restored the upgrade-babel-runtime branch January 29, 2021 20:24
@thomaswelton
Copy link
Author

I found that it wasn't needed as I upgraded all of the babel deps in ours project which did the same trick and have had this working for a while. But I can reopen this PR if you'd like

@thomaswelton thomaswelton reopened this Jan 29, 2021
@Methuselah96
Copy link
Collaborator

@thomaswelton Thanks for the PR! Unfortunately I don't have access to push to your branch in order to resolve the merge conflicts. Do you mind if I just create a new PR?

@thomaswelton
Copy link
Author

Sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 support. ESM strict mode
3 participants