win, fs: mkdir really return UV_EINVAL for invalid names

Makes uv_fs_mkdir return UV_EINVAL for invalid directory names instead of UV_ENOENT. Refs: nodejs/node#31177 PR-URL: libuv#2601 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
JeffroMF · May 16, 2022 · b1399b8 · b1399b8
1 parent 6799191
commit b1399b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/win/fs.c b/src/win/fs.c
@@ -1218,7 +1218,8 @@ void fs__mkdir(uv_fs_t* req) {
     SET_REQ_RESULT(req, 0);
   } else {
     SET_REQ_WIN32_ERROR(req, GetLastError());
-    if (req->sys_errno_ == ERROR_INVALID_NAME)
+    if (req->sys_errno_ == ERROR_INVALID_NAME ||
+        req->sys_errno_ == ERROR_DIRECTORY)
       req->result = UV_EINVAL;
   }
 }

diff --git a/test/test-fs.c b/test/test-fs.c
@@ -4437,6 +4437,7 @@ TEST_IMPL(fs_invalid_mkdir_name) {
   loop = uv_default_loop();
   r = uv_fs_mkdir(loop, &req, "invalid>", 0, NULL);
   ASSERT(r == UV_EINVAL);
+  ASSERT_EQ(UV_EINVAL, uv_fs_mkdir(loop, &req, "test:lol", 0, NULL));
 
   return 0;
 }