Fix the dtInterval adjunstment on output time using adaptive and #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems with the precision of the time_to_output calculation cause errors in setting the correct time step at output time and final time in the em_b_wave ideal test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems with the precision of the time_to_output calculation cause errors in setting the correct time step at output time and final time in the em_b_wave ideal test (After removing the same mitigation code)
TYPE: bug fix
KEYWORDS: 5 to 10 words related to commit, separated by commas
SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member
DESCRIPTION OF CHANGES:
Problem:
For the time_to_output calculation, the current simulation time is used as a float. This sometimes causes the time_to_output to be inaccurate, leading to problems, especially at the end of the simulation."
Solution:
I determinate the time_to_output using the current simulation time in TimeInterval type, avoiding the numeric.
ISSUE:
wrf-model#2103
LIST OF MODIFIED FILES:
/dyn_em/adapt_timestep_em.F
TESTS CONDUCTED:
RELEASE NOTE: Corrected source o problems realted to