Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about <> </> #116

Closed
bluelovers opened this issue Jan 31, 2020 · 7 comments
Closed

about <> </> #116

bluelovers opened this issue Jan 31, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@bluelovers
Copy link
Contributor

image

i think maybe need make <> and </> style is match

export default <></>
@philippnurullin
Copy link
Member

@bluelovers Hi, can you be more specific? Is you suggesting that the < & > should be connected to the / from the both ends?

@bluelovers
Copy link
Contributor Author

bluelovers commented Feb 10, 2020

i feel </> looks too big then <>, maybe change <> a little bigger? or same as </> but without / and connected

or make </> a little small

@philippnurullin
Copy link
Member

@bluelovers Ok, see what you talking about. Will look in to it in v1.0.4

@auduchinok
Copy link
Member

Just to note: <> is also used as an operator in some languages (VB.NET, OCaml, F# come to mind) and making it significantly bigger would probably make it look a bit worse.

@philippnurullin
Copy link
Member

@auduchinok Sure, thanks. Can you paste some code examples if you have them?

@bluelovers
Copy link
Contributor Author

jsx

function getGreeting {
  return <>Hello, Stranger.</>;
}

@auduchinok
Copy link
Member

auduchinok commented Feb 10, 2020

@philippnurullin Sure! Here's some F#:

match reference.Module with
| :? IProjectPsiModule as projectPsiModule ->
    let referencedProject = projectPsiModule.Project
    if referencedProject <> project then
        result.Add(referencedProject.GetOutputFilePath(psiModule.TargetFrameworkId).FullPath)
| _ -> ()
if moduleKind <> AnonModule then
    x.ProcessReferenceNameSkipLast(lid)

Here's some VB.NET:

Protected Overrides Sub Run(methodDeclaration As IMethodDeclarationBase, data As ElementProblemAnalyzerData, consumer As IHighlightingConsumer)
  If methodDeclaration.Kind <> MethodDeclarationKind.SUB Then
    Return
  End If

  If methodDeclaration.AsKeyword IsNot Nothing Then
    consumer.AddHighlighting(New SubCannotHaveReturnTypeError(methodDeclaration))
  End If
End Sub

@philippnurullin philippnurullin added the enhancement New feature or request label Feb 10, 2020
philippnurullin added a commit that referenced this issue Mar 11, 2020
— Added No Ligature version. Only in `.ttf` format. It called **JetBrains Mono NL**. #19
— Fixed problems with tiny gaps between the Box Drawing elements. #84
— Balanced the size of `<>` `</>` ligatures to match in mass. #116
— Fixed problem with not working `<--` ligature. #95
— Added `U+FEFF` symbol. No-break zero space. #147
— `<!--` `-->` ligatures now should be on the same heights. #77
— Corrected `===>` behaviour in loading sequences. #151
— Corrected `A` placement in italics.
— Made dot in the `0` smaller, so it will be more distinguishable from `8` at small sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants