Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=== ligature isn't evenly spaced at 13px #25

Open
yishn opened this issue Jan 16, 2020 · 23 comments
Open

=== ligature isn't evenly spaced at 13px #25

yishn opened this issue Jan 16, 2020 · 23 comments
Milestone

Comments

@yishn
Copy link

yishn commented Jan 16, 2020

At the recommended font size of 13px, the === ligature doesn't look evenly spaced:

=== ligature

@jakeweary
Copy link

jakeweary commented Jan 16, 2020

Yeah, this is the only issue I have so far. 15px seems to be the minimal font size where === looks nice in VSCode. But the font itself doesn't feel right on that size, so it's actually 16px where I'm happy. I'd like to use it on 14px or so.

Other than that, pretty soild font. 👍

@philippnurullin
Copy link
Member

Yes, thats a problem. It appears on low dpi Win & Linux. Cant say the exact date when it will be fixed. Looks like it needs manual hinting. We will look in to that.
Thanks for feedback!

@aaronbell
Copy link

Definitely would recommend manual hinting if you’re looking to achieve good results at lower dpi screens :).

@gwk
Copy link

gwk commented Jan 17, 2020

I encourage the developers to try to make this glyph look legible at low dpi 12px as well (and less if possible). This is the only issue I have seen so far that discourages me from using the font daily. Thanks for your efforts!

@EnderPicture
Copy link

This is my only gripe about this font so far, and since 13 is the suggested font size, I expected that it should look the best at that font size.
Other than that, very nice.

@philippnurullin philippnurullin added the bug Something isn't working label Jan 22, 2020
@vbsessa
Copy link

vbsessa commented Feb 14, 2020

Same using 14px here.

@qgates
Copy link

qgates commented Feb 15, 2020

=== stil looks imbalanced at a number of font sizes from 22 down.

@philippnurullin philippnurullin added hinting bug and removed bug Something isn't working labels Mar 16, 2020
@SQReder
Copy link

SQReder commented May 13, 2020

Bump for this. Look broken at recommended 13px and 14px.
Win 10, WebStorm 2020.1.1
image
image

@silkfire
Copy link

silkfire commented Jul 10, 2020

@philippnurullin What's the status of this issue? Did it make it into the latest release?

@philippnurullin
Copy link
Member

Hi @silkfire , don't have a good solution for that yet.

@RosaWagner
Copy link
Contributor

RosaWagner commented Sep 23, 2020

Try to have the exact same space between the bars? right now is it 140 and 136 (in Light master), at small ppm size, it can create a difference. Enlarge it even a little bit, like 180 or 200 units between each bar… it may help the rasteriser to render it better ?

@philippnurullin
Copy link
Member

Ok, will explore in this direction.

@philippnurullin
Copy link
Member

In the v2.200 we able to reproduce this issue only on Linux. So please test do you have any changes after updating.

@philippnurullin philippnurullin modified the milestones: v2.200, v2.3000 Oct 21, 2020
@trygveaa
Copy link

Nice, now it's much improved at most font sizes. Here are my results for different font sizes between 6 and 20:

Looks good in 2.200, and didn't look good in 2.002:
10
11
14
15
17
18
19

Looks good in 2.200 and looked the same in 2.002:
8
12
20

Doesn't look good in 2.200, and looked the same in 2.002:
9

Looks different in 2.200 from 2.002, but none of the versions look good:
6
7
13

Looks worse in 2.200, looked good in 2.002:
16

This is on Arch Linux in the kitty terminal emulator on a 1920x1080 96 DPI display.

@philippnurullin
Copy link
Member

Hi @trygveaa . Thanks for the detailed report. The 6-9 are not sizes to work comfortably with. So the real problem are 13, 16. I'll see what can be done further in the next update.

@trygveaa
Copy link

Yes, I agree. Personally I use 11, so I'm happy.

@philippnurullin
Copy link
Member

Hi @trygveaa I want to tune the === more. Can you upload the screenshots with problematic rendering at 13, 16? It will be a great help.

@trygveaa
Copy link

Sure, here is 13:
image

And 16:
image

This is with the ttf files currently in the repo, i.e. version 2.211.

@trygveaa
Copy link

For comparison, here is 16 from version 2.002, i.e. when it looked good:
image

philippnurullin added a commit that referenced this issue Apr 21, 2021
- Made triple equal ligature === more spacious #25
- Added 70 symbols from #47
- Tuned # #275
- Added =: ligature #305
- Added floor and ceiling mathematical characters #328
- Corrections in Θ θ ξ Σ ∑ #351
- Added Cyrillic Kazakh letters #391
- Added ligature ;;; #393
- The ligature <- have 3 digit exclusion #403
- Fixed regression with <-- ligature #417
- Fixed interpolation error in Italic #431
- Corrected placement of * in */ ligature in Regular master
- Tuned Ч ч
- Rounded corners in ⚠
@philippnurullin
Copy link
Member

Hi, please test the new version in the latest push. Thanks in advance!

@trygveaa
Copy link

trygveaa commented Apr 21, 2021

I generated images for how it looks in sizes 8 to 20 in version 2.230, and ran some git bisects to compare old and newer versions.

In my opinion these are the ones that don't look as good as they have previously. This is the latest version a size looked good in, and the first version it looks worse in:
Sizes 8, 14 and 15 looked good in v2.225 (acab62a), but looks worse in v2.230 (f668e09).
Size 12 looked good in v2.211 (cb0730c), but looks worse in v2.220 (7445d1f) (same in v2.230 as in v2.220).
Size 16 looked good in v2.002 (0d9ba3f), looked a bit worse in 400d12f and changed again to a bit worse than that in v2.220 (7445d1f) (same in v2.230 as in v2.220).
Sizes 18 and 19 looked good in v2.211 (cb0730c), but looks slightly worse in v2.220 (7445d1f) and changed again to a bit worse than that in v2.230 (f668e09).

Size 13 looks good in 2.230, which is an improvement over previous versions.

Sizes 10, 11, 17 and 20 looked good previously, and still looks good in v2.230.

Size 9 didn't look good previously, and still doesn't.

Here's how it looks for me in v2.230:

Size 08:
triple_equals_size_08_original
Size 09:
triple_equals_size_09_original
Size 10:
triple_equals_size_10_original
Size 11:
triple_equals_size_11_original
Size 12:
triple_equals_size_12_original
Size 13:
triple_equals_size_13_original
Size 14:
triple_equals_size_14_original
Size 15:
triple_equals_size_15_original
Size 16:
triple_equals_size_16_original
Size 17:
triple_equals_size_17_original
Size 18:
triple_equals_size_18_original
Size 19:
triple_equals_size_19_original
Size 20:
triple_equals_size_20_original

Scaled up:

Size 08:
triple_equals_size_08_scaled
Size 09:
triple_equals_size_09_scaled
Size 10:
triple_equals_size_10_scaled
Size 11:
triple_equals_size_11_scaled
Size 12:
triple_equals_size_12_scaled
Size 13:
triple_equals_size_13_scaled
Size 14:
triple_equals_size_14_scaled
Size 15:
triple_equals_size_15_scaled
Size 16:
triple_equals_size_16_scaled
Size 17:
triple_equals_size_17_scaled
Size 18:
triple_equals_size_18_scaled
Size 19:
triple_equals_size_19_scaled
Size 20:
triple_equals_size_20_scaled

Here is the command I used to generate the images:

for font_size in {8..20}; do file=$(printf 'triple_equals_size_%02d_original.png' $font_size); kitty --config NONE -o "font_size $font_size" sh -c "printf '===\n\n\n\n' && sleep 1 && maim -u -g 100x50+0+29 $file && mogrify -trim -bordercolor black -border 5 $file && convert -scale 300 $file ${file/original/scaled}"; done

@carlosala
Copy link

this continues to happen, any workaround?

@Calinou
Copy link

Calinou commented Apr 5, 2023

This should be fixed by 2.304: https://github.com/JetBrains/JetBrainsMono/releases/tag/v2.304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests