-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jet Brains Mono update #691
Conversation
…hs. by adding ǏǑǓǛǗǙǕɛ
…in metrics. Upright: fixed win metrics
Hi @emmamarichal As I can see you modified the vertical metrics (Win). This will result in the massive problem four our users. We encountered a lot of feedback when the last time we increased it. A lot of developers are very sensitive about the amount of vertical space the font takes. Have a nice day. |
Hi @philippnurullin!
We are also very vigilant about the regressions that modifications to vertical metrics can cause, as we understand that this can break certain layouts on the web. These are changes that we never accept in font updates because, as you mentioned, it's too risky. However, only changes to the |
Hi @philippnurullin, |
Thanks for your patience. |
@philippnurullin Yes sure! Win metrics changes don't cause regressions, and we can update them. |
Hello @philippnurullin!
(feel free to tag anyone else in your team, if they are related to this update)
I'm Emma, I work with the Google Fonts team, as font onboarder, and I prepared that PR to answer to this issue: google/fonts#7881
I reviewed the last version of the exported fonts, and found a couple of issues. You will find in the commits all the details.
They are only technical fixes, nothing concerns the design.
To fix that fail
🔥 FAIL Ensure the font supports case swapping for all its glyphs.
, I had to add the following glyphs:ǏǑǓǛǗǙǕɛ
. For accented letters, they have been generated automatically, but forɛ
, it would need some design work. For now, I replaced it by the cap version, but feel free to update it for the next version.So, if all is good for you, you can merge that PR, and I'll be happy then to push the update on the API server :)
Don't hesitate if you have any questions,
Cheers!