Fix fling velocity for precise wheel scroll #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Jun 13, 2024
| @@ -211,6 +224,7 @@ internal class MouseWheelScrollNode( | |||
| return | |||
| } | |||
| var animationState = AnimationState(0f) | |||
| var waitNextEventTimeMs = 0 | |||
There was a problem hiding this comment.
dispatchMouseWheelScroll becomes complex and needs refactoring (and tests) in the future. We can make it more understandable with less bugs by reducing/combining states and reading them more closely to where they are written.
There was a problem hiding this comment.
Simplifying/refactoring is always welcome, but it's probably not a blocker here
...oundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/MouseWheelScrollable.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/fix-mouse-fling-velocity
branch
from
0e31f2e to
6327a13
Compare
igordmn
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fling velocity for precise wheel scroll by taking into account time between events
Testing
Manually, by pager snap behaviour
Release Notes
Fixes - Desktop