Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on on pre/post instrumentation task for testFixtures, possibly other sourceSets #1214

Closed
bric3 opened this issue Nov 23, 2022 · 1 comment
Labels
Milestone

Comments

@bric3
Copy link
Contributor

bric3 commented Nov 23, 2022

Describe the bug
Instrumentation fails to ignore or recognize other source sets.

> Configure project :modules:core
[gradle-intellij-plugin :modules:corecore] Unexpected instrumentation task name: instrumentTestFixturesCode
[gradle-intellij-plugin :modules:corecore] Unexpected instrumentation task name: postInstrumentTestFixturesCode

To Reproduce
Steps to reproduce the behavior – provide your build configuration, and/or link to the failing GitHub Action job.

Adding the plugin id("java-test-fixtures"), will add a new source set testFixtures, gradle-intellij-plugin (as do other plugins) will react to this and create the above mentioned tasks.

Expected behavior
No warnings, I believe testFixtures are part of gradle and should be supported. That said is this really an issue if there are other source sets, like integrationTests, etc.

Environment:

  • OS: macOS
  • Gradle IntelliJ Plugin Version: 1.9.0
  • Gradle Version: 7.5.1
@bric3 bric3 added the bug label Nov 23, 2022
@YannCebron
Copy link
Member

#1081 sounds related

@hsz hsz added this to the next milestone Dec 19, 2022
@hsz hsz closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants