This repository has been archived by the owner on Oct 22, 2019. It is now read-only.
Store metrics immediately to redis #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also introduce an InMemory storage adapter for unit testing.
and internal values property, since the state is stored directly in redis everywhere.
schnipseljagd
force-pushed
the
store-metrics-immediately-to-redis
branch
from
afa0be8
to
de0a6ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we think bash updates are a premature optimization for now.
This allows us to simplify a lot and makes the implementation of
inc,dec,incBy,decByon the Gauge much simpler.This brings also a
InMemorystorage adapter for unit testing.refs: #6