Flush only metric data from Redis instead of complete server #81
Conversation
|
ping. |
|
Hi @jlis, thank you for your contribution! Would you mind adding a test case that validates that no other data is removed from the Redis instance? Thanks! |
|
@seiffert I added the tests as requested :) |
| * @param $job | ||
| * @param $groupingKey | ||
| * @param $method | ||
| */ | ||
| private function doRequest(CollectorRegistry $collectorRegistry, $job, $groupingKey, $method) | ||
| private function doRequest(CollectorRegistry $collectorRegistry = null, $job, $groupingKey, $method) |
There was a problem hiding this comment.
What argument errors does this prevent? When do they occur?
There was a problem hiding this comment.
When running the blackbox tests, I'm getting an argument error/notice since the CollectorRegistry is expected but null is given in PushGateway::delete() method.
There was a problem hiding this comment.
See #82.
There was 1 error:
1) Test\BlackBoxPushGatewayTest::pushGatewayShouldWork
Argument 1 passed to Prometheus\PushGateway::doRequest() must be an instance of Prometheus\CollectorRegistry, null given, called in /var/www/html/src/Prometheus/PushGateway.php on line 54 and defined
/var/www/html/src/Prometheus/PushGateway.php:63
/var/www/html/src/Prometheus/PushGateway.php:54
/var/www/html/tests/Test/BlackBoxPushGatewayTest.php:36
|
Ping |
|
any news on this one? |
|
Nah, I guess the repo is dead. |
|
This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there. |
How it currently behaves:
After the
flushRedis()method is called, the complete Redis server incl. all databases is flushed usingFLUSHALL. One dedicated Redis server/cluster is required to use the Redis adapter.How it should behave:
Only the metric data (the keys and the actual metrics) are deleted via a LUA script. A shared Redis server/cluster can be used for collecting metrics using the Redis adapter.
I also switched from PHPUnit 4.1.0 to ~5.7 since >=PHP 5.6.3 is required in the composer file.