Allow importing templates from an http or https remote #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffref
requested changes
Nov 18, 2023
There was a problem hiding this comment.
Hey @arthurmelton! Thanks for opening this PR ❤️.
Just small comments, feel free to request a review again when you've made the changes.
Please update the readme and the flag according to this new feature.
Thanks again!
|
I should have resolved the things you requested @Joffref. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fulfill and satisfy the requirements in this issue #18. It does not download the file because I could not see any need to do so, it just makes it go off of memory.