feat(#24): parse struct method comments #34

leorolland · 2023-12-31T13:27:46Z

closes #24

Joffref · 2024-01-04T11:30:56Z

Before reviewing this, why shouldn't we create a new method: parseMethodWithComment? Thus we won't have any nil arguments in the interface parser.

This method can wrap the call to parseMethod and the parseComments logic.

Would you have any thoughts on that? Feel free to ping me back to clarify 💯

internal/parser/methods.go

internal/parser/struct.go

Joffref

LGTM

leorolland force-pushed the parse-struct-methods-comments branch from 52f2739 to 92e9eae Compare December 31, 2023 13:28

leorolland requested a review from Joffref December 31, 2023 13:30

leorolland added the enhancement New feature or request label Dec 31, 2023

leorolland force-pushed the parse-struct-methods-comments branch from 92e9eae to 3dbe468 Compare January 5, 2024 17:01

Joffref reviewed Jan 5, 2024

View reviewed changes

internal/parser/methods.go Outdated Show resolved Hide resolved

internal/parser/struct.go Show resolved Hide resolved

feat(#24): parse struct method comments

7d4a917

leorolland force-pushed the parse-struct-methods-comments branch from 3dbe468 to 7d4a917 Compare January 6, 2024 14:41

Joffref approved these changes Jan 6, 2024

View reviewed changes

Joffref merged commit 277ca20 into master Jan 6, 2024
8 checks passed

Provide feedback