Enable building local Tor by default?

[kristapsk]

See #1440 (comment).

Should we switch from off by default to on by default? Could help some users. Only downside I see is longer running time of install.sh. Thoughts?

[roshii]

Someone using joinmarket is most likely privacy aware and would most likely have its bitcoin node running behind tor.
Based on that assumption, building local tor should be off by default.

We can also consider that tor is a prerequisite, like a synced node is. Based on that consideration, it should be off by default aswell.

[kristapsk]

We can also consider that tor is a prerequisite, like a synced node is.

Technically it's not. It is possible to use JoinMarket without Tor, using IRC as only coordination method. And it is kinda ok if you are using VPN.

Based on that consideration, it should be off by default aswell.

Why? Prerequisites could be bundled in. Like Wasabi Wallet does with both Tor and Bitcoin Knots.

[roshii]

Technically it's not. It is possible to use JoinMarket without

That is, in my opinion, another argument for not building it by default.

Why? Prerequisites could be bundled in.

Could be indeed, it makes it handy if you have nothing else to install. Installing and syncing a node remains manual and so I don't think bundling prerequisites has advantages here. It is kind of handy but should not be default. It also gives user ability to update tor independently.

[PulpCattel]

I would also prefer to leave default off, but that's just a personal preference. I don't know what would be best for the users.