Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build local Tor by default and remove --develop #1497

Closed
wants to merge 1 commit into from

Conversation

kristapsk
Copy link
Member

We already build Qt GUI for tests and don't actually do anything with it, makes sense to also test building Tor. Also, remove --develop, as, since #1490 editable installs is removed, so adding legacy --develop flag makes no sense.

Somewhat related - #1496.

@roshii
Copy link
Contributor

roshii commented Jun 5, 2023

Editable installs is temporarely removed as far as I see it, --develop flag would make a come back with a structural fix for editable installs.

It does not arm to remove it for now though.

@kristapsk
Copy link
Member Author

--develop was restored with #1484 and building Tor very time in CI is questionable gain, closing.

@kristapsk kristapsk closed this Oct 6, 2023
@kristapsk kristapsk deleted the ci-with-local-tor branch October 6, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants