Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade setuptools also with --docker-install #1572

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Upgrade setuptools also with --docker-install #1572

merged 1 commit into from
Oct 7, 2023

Conversation

kristapsk
Copy link
Member

This was missed in #1484.

@roshii
Copy link
Contributor

roshii commented Oct 7, 2023

Thinking out loud: considering pip install -U setuptools fails on debian-bookworm, wouldn't it be best to just check for setuptools version on docker install, and report to user if not meeting requirement?

@kristapsk
Copy link
Member Author

@roshii As I understand, bookworm does not allow any global Python package installs, so --docker-install will actually make no sense there, virtual environment will needed to be created anyway. This switch is kinda hack for easier install for stuff like Jam development Docker images.

roshii
roshii approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@roshii roshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 7181512

@kristapsk kristapsk merged commit cade771 into JoinMarket-Org:master Oct 7, 2023
20 checks passed
@kristapsk kristapsk deleted the docker-install-upgrade-setuptools branch October 7, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshii roshii roshii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapsk @roshii