Fix to respect the AutoDetect setting. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2023 07:03
- Conditional should be checking "if variable == true" not "if variable := true" as the latter is equivalent to "if true", which negates the need to have a conditional check.
…tionality. - When the BrivUserSetting "AutoCalculateBrivStacks" is set to True, the BrivUserSetting "TargetStacks" should be ignored when determining how many stacks Briv needs. AutoCalculate uses TargetStacks - LeftoverStacks where "TargetStacks" are how many stacks are needed to go from area 1 to modron reset, and "LeftoverStacks" are how many stacks are expected to be unused when reaching the modron reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows the check for stacks after stacking to use the
AutoDetectsetting when it is enabled. Previously stacks were being compared against theTarget Haste stackseven thoughAutoDetectdoes not use that value.Also corrected the conditional check for write settings in the addon's reload settings method used by the Gem Farm Script.