(Suspended) Download Attachments on click
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@JonasMuehlmann H e l p Everything else is bound with Frontend (UI, Command, Model etc.), I just can't test it because of this. |
…asMuehlmann/BIB_VPR into download-attachment-on-click
Can you try logging the output of It says actually in the logging, but that outputs valid one The path accessed is a valid one. |
|
@JayKim94 Do the tests pass on your system?There might be some differences between Linux and Windows that I did not account for. |
|
@JonasMuehlmann I also don't know if it worked before because at that time we didn't have any View to show them. I just assumed it would work because of the test results. |
|
Tests also failed. |
Interesting, wanna have a chat about this on teams? |
Temporarily closed until we figure out how to deal with local files in UWPIssue #149 is also on suspend |
JayKim94
added
discussion
JayKim94
changed the title
Attachments on clickAttachments on click
JayKim94
changed the title
Attachments on clickAttachments on click
JayKim94
changed the title
Attachments on clickAttachments on click
5 tasks
JonasMuehlmann
modified the milestones:
Sprint 2,
Final Feature and Documentation Sprint
2 tasks
cjaak
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR can be merged, the following checkboxes have to be ticked
MessengerServiceif appropiateConsole.Writeline()statements used for debuggingRelated issues:
closes #149
in development