Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend implementation of notifications #210

Merged
merged 72 commits into from
Jul 27, 2021
Merged

Conversation

JonasMuehlmann
Copy link
Owner

@JonasMuehlmann JonasMuehlmann commented Jun 29, 2021

Before this PR can be merged, the following checkboxes have to be ticked

  • This code belongs to the backend and is tested, or tests are not useful
  • New functions with more than 5 lines have docstrings
  • New code has been integrated with the MessengerService if appropiate
  • New code has been integrated with the SignalRService if appropiate
  • New functions or classes have been documented in the Entwurfsdokumentation
  • Changes introduce no commented out code or Console.Writeline() statements used for debugging

Related issues:

@JonasMuehlmann JonasMuehlmann added this to the Optional features milestone Jun 29, 2021
@JonasMuehlmann JonasMuehlmann linked an issue Jun 29, 2021 that may be closed by this pull request
15 tasks
@JonasMuehlmann JonasMuehlmann requested a review from JayKim94 July 25, 2021 13:53
@JonasMuehlmann JonasMuehlmann added status: review_phase Implementation is finished, except for potential feedback and removed status: in development labels Jul 27, 2021
@JayKim94
Copy link
Collaborator

JayKim94 commented Jul 27, 2021

@JonasMuehlmann I am not sure if I understood how Mute works. If a user gets 'muted' by another user, the muted user can not send notifications to that user any more correct? Sonst sieht's gut aus

@JonasMuehlmann JonasMuehlmann enabled auto-merge July 27, 2021 12:50
@JonasMuehlmann JonasMuehlmann merged commit 6df2ffe into unstable Jul 27, 2021
@JonasMuehlmann
Copy link
Owner Author

@JonasMuehlmann I am not sure if I understood how Mute works. If a user gets 'muted' by another user, the muted user can not send notifications to that user any more correct? Sonst sieht's gut aus

@JayKim94 Yes, if I add a mute for a specific combination of notification -source, -sender and -event(e.g. you reacting to my messages in the team xyz), I will not get a notification of that event occurring in other views or while I am offline. The only way to find out about it is opening the corresponding view and inferring the event from the content of e.g. the new message in a chat, a new team in my teams navigation, etc.

@JonasMuehlmann JonasMuehlmann deleted the notifications branch August 4, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_dependency Requires other issues to be closed status: review_phase Implementation is finished, except for potential feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of notifications
2 participants