Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Reload for Teams and Chats #322

Merged
merged 10 commits into from
Aug 16, 2021
Merged

Implemented Reload for Teams and Chats #322

merged 10 commits into from
Aug 16, 2021

Conversation

JayKim94
Copy link
Collaborator

@JayKim94 JayKim94 commented Aug 16, 2021 •
edited
Loading

We have nun endlich Reload Buttons!!!!

image

Related issues:

closes #303

@JayKim94 JayKim94 added status: review_phase Implementation is finished, except for potential feedback binding binding frontend with backend labels Aug 16, 2021
@JayKim94 JayKim94 self-assigned this Aug 16, 2021
This was referenced Aug 16, 2021
Closed
Closed
@JayKim94
Copy link
Collaborator Author

@JonasMuehlmann We are getting bulid errors in FileSharingServiceTest, I think that's because @robbelDev has updated FileSharingService.Download() method. We need to changed the test, because the new download method works, whereas the old does not

@JonasMuehlmann
Copy link
Owner

@JonasMuehlmann We are getting bulid errors in FileSharingServiceTest, I think that's because @robbelDev has updated FileSharingService.Download() method. We need to changed the test, because the new download method works, whereas the old does not

@JayKim94 I have already fixed everything wrong with that PR, though I did so in #316. I could take those changes and move into a new PR...

@JonasMuehlmann JonasMuehlmann merged commit 3954156 into unstable Aug 16, 2021
@JonasMuehlmann JonasMuehlmann deleted the implement-reload-button branch September 24, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasMuehlmann JonasMuehlmann JonasMuehlmann approved these changes

@robbelDev robbelDev Awaiting requested review from robbelDev

Assignees

@JayKim94 JayKim94

Labels
binding binding frontend with backend status: review_phase Implementation is finished, except for potential feedback
Projects
None yet
Milestone
Final Feature and Documentation Sprint
Development

Successfully merging this pull request may close these issues.
2 participants
@JayKim94 @JonasMuehlmann