Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation Notification & ToastNotification #323

Merged
merged 30 commits into from
Aug 18, 2021
Merged

Implementation Notification & ToastNotification #323

merged 30 commits into from
Aug 18, 2021

Conversation

JayKim94
Copy link
Collaborator

@JayKim94 JayKim94 commented Aug 16, 2021 •
edited
Loading

Before this PR can be merged, the following checkboxes have to be ticked

`

  • New functions with more than 5 lines have docstrings
  • New code has been integrated with the MessengerService if appropiate
  • New code has been integrated with the SignalRService if appropiate
  • New functions or classes have been documented in the Entwurfsdokumentation
  • Changes introduce no commented out code or Console.Writeline() statements used for debugging

Related issues:

#172

Notification had DB issue, therefore ToastNotifications are sent more extensively as an alternative solution

Toast is sent on: StateProvider.Initialize(), EventProvider.MessageReceived, EventProvider.InvitationReceived, CacheQuery.Reload()

ToastNotification is this thing

image
image

@JayKim94 JayKim94 self-assigned this Aug 16, 2021
JayKim94 added 15 commits August 16, 2021 19:42
@JayKim94
refactored toast related methods from StateProvider to ToastService
ca88394
@JayKim94
added logging in ToastService
c89a891
@JayKim94
EventProvider sends Toast on MessageReceived and InvitationReceived
a4c2bf2
@JayKim94
implemented ToastActivatedEvent in App.xaml.cs
ee347c5
@JayKim94
removed frontend models for Notification
15ca9e3
@JayKim94
implemented SendNotificationToUser in ChatHub
2b2b1b2
@JayKim94
SignalRService provides ReceiveNotification event
5f68a10
@JayKim94
MessengerService sends Notification upon SendInvitation
8055475
@JayKim94
extended BroadcastOptions for Notifications
f2acb76
@JayKim94
EventProvider provides Broadcast for notifications and listens for si…
dcf0ced 
…gnalr
@JayKim94
StateProvider loads all notifications from the database upon initiali…
b8549a3 
…zation
@JayKim94
CacheQuery provides GetNotifications
1ece67e
@JayKim94
added view models for notification data model
55303dd
@JayKim94
implemented in InboxControlViewModel
a720620
@JayKim94
reflected code changes in the views
93d01d1
@JayKim94 JayKim94 added status: review_phase Implementation is finished, except for potential feedback and removed status: in development labels Aug 17, 2021
robbelDev
robbelDev previously approved these changes Aug 18, 2021
View reviewed changes
@robbelDev robbelDev merged commit c8c17fd into unstable Aug 18, 2021
@JayKim94 JayKim94 mentioned this pull request Sep 15, 2021
Open
15 tasks
@JonasMuehlmann JonasMuehlmann deleted the implement-notification-system branch September 24, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbelDev robbelDev robbelDev approved these changes

Assignees

@JayKim94 JayKim94

Labels
frontend status: review_phase Implementation is finished, except for potential feedback
Projects
None yet
Milestone
Final Feature and Documentation Sprint
Development

Successfully merging this pull request may close these issues.
2 participants
@JayKim94 @robbelDev