Support Bus::dispatchChain
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvh
commented
May 10, 2023
|
|
||
| return $this->areClassesSame($variableClass, $subjectClass); | ||
| return count($variableClasses) === 1 && $this->areClassesSame($variableClasses[0], $subjectClass); |
There was a problem hiding this comment.
@JonasPardon this is for backwards-compatibility, but you may have more context around the use cases here.
joelvh
commented
May 10, 2023
| @@ -100,16 +107,21 @@ public function getMethodCalls( | |||
| throw new Exception('Static calls within method calls are not supported yet. If this is a Bus::chain, support is coming.'); | |||
| } | |||
|
|
|||
| throw new Exception('Not supported yet. Please open an issue here: https://github.com/JonasPardon/laravel-event-visualizer/issues/new'); | |||
| // throw new Exception('Not supported yet. Please open an issue here: https://github.com/JonasPardon/laravel-event-visualizer/issues/new'); | |||
There was a problem hiding this comment.
@JonasPardon disabled this to avoid breaking this loop.
joelvh
commented
May 10, 2023
| method: $node->name->toString(), | ||
| ); | ||
| })->toArray(); | ||
| return collect($this->resolveClassesFromArgument($node->args[0])) |
There was a problem hiding this comment.
@JonasPardon there may be a cleaner way to do this.
This was referenced May 10, 2023
|
Hi @joelvh, this all looks good to me. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Bus::dispatchChain. This change introduces the idea that multiple classes can be resolved rather than a single class.Tests are added for an array of jobs as an argument or assigned to a variable.
I've also removed the exception when an unsupported dispatch call is encountered in order to avoid exiting early.
See #8 for some discussion about this.