Return the body of user request as output #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to output the body of the request instead of HTTP Response or Returning True, this makes it more consistent.
Jordan-Prescott
requested changes
Sep 16, 2024
odins_spear/requester.py
Outdated
| @@ -32,8 +32,6 @@ def delete(self, endpoint, data=None): | |||
|
|
|||
There was a problem hiding this comment.
I've had a think about this and I've landed on just returning the status code. I think returning what is sent it pointless because the developer either has that already or it will be wiped from memory straight away in a loop. Lets other some more functionality but keep it light with the status code.
Change it to 'return response.status_code'
Jordan-Prescott
previously approved these changes
Sep 17, 2024
…-that-return-nothing
Jordan-Prescott
deleted the
103-return-true-if-no-errors-for-the-methods-that-return-nothing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #103