Add API exception #113
Merged
Add API exception #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the API exception alongside cleaned up a few area that have been made redundant
odins_spear/requester.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import requests | |||
| import json | |||
| from . import exceptions | |||
There was a problem hiding this comment.
Change to ' from .exceptions import OSAPIResponseError
When importing its good to keep them as light as possible getting only what you need.
Jordan-Prescott
requested changes
Sep 16, 2024
odins_spear/requester.py
Outdated
| try: | ||
| response.raise_for_status() | ||
| except requests.exceptions.RequestException: | ||
| raise exceptions.OSApiResponseError(response) |
There was a problem hiding this comment.
Adjust inline with first comment.
| @@ -92,6 +93,12 @@ def _rate_limited_request(self, method, endpoint, data=None, params=None): | |||
| self.logger._log_request(endpoint=endpoint, response_code=response.status_code) | |||
|
|
|||
| # flags errors if any returned from the API | |||
| response.raise_for_status() | |||
| return response.json() | |||
| try: | |||
There was a problem hiding this comment.
Add this to the the _request method. Its only applied to the rate limited version.
Jordan-Prescott
deleted the
111-add-an-api-exception-which-passes-through-odin-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the API exception alongside cleaned up a few area that have been made redundant
This allows for more descriptive error handling when a request exception occurs
Previous:
New: