100 review scripter features return only json new #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for Return JSON issue. Please check I know there are some I have missed. Thanks
Update to find_alias, Ran into an issue with AA where if NO AA is present it will crash, this code has currently been commented out to test new changes.
Will need to be reviewed as AA is causing issues. All workarounds removed
Jordan-Prescott
requested changes
Sep 27, 2024
review issues resolved.
Jordan-Prescott
deleted the
100-review-scripter-features-return-only-json-new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to now output JSON dict instead of string,
Will need to check Find_Alias.py as AA is currently hanging as empty dict is pulled if a site has no AA setup which causes it to stop.