127 auto attendant functionality #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added delete.auto_attendant method
Added auto_attendant_submenu method into delete.py
Added auto_attendant_user to get.py
Added auto_attendant_submenus method to get.py
Added auto_attendant_submenu_usage method to get.py
Added auto_attendant method to post.py
Added auto_attendant_remove_user and auto_attendant_submenu methods into post.py
Corrected typo
Jordan-Prescott
requested changes
Oct 28, 2024
| """ | ||
|
|
||
| endpoint = "/groups/auto-attendants" | ||
|
|
There was a problem hiding this comment.
This needs update the existing payload otherwise your overwriting whatever is passed in the param.
Example:
payload['groupId'] = group_id
There was a problem hiding this comment.
Additionally things where you have hard coded like "nameDialingEntries":"LastName + FirstName" we need to check this is empty and not passed in by the user before editing.
There was a problem hiding this comment.
I've resolved this and pushed new commits.
Corrected typo in post.auto_attendant_submenu method
Updates post.auto_attendant method to ensure payload is not overwritten when passed as a parameter
Jordan-Prescott
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new methods: