Call flow graph 2 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for when the JSON object comes from the API the developer can create an object from that JSON
Here I should have some examples for a perfect object for these methods. I should change the lists in the obkect to IF NONE = NONE. Instead of defaulting it to a list. Then in the from_dict I could set to None if doesnt exist.
Need to confirm when this method will be used as the objects are conflicting such as a list of agents in the response back from hunt group
Hit the issue of agent in the dict but not made, when do I build each? either way there has to be some update. build hunt group then add in agents build users and then add to hunt groups
Issue found - CC and HG data not complete ready for traversing need to add these in.
Next is hunt groups and auto attendants
Need to clean up calling the method
Next I need to pull in the call forwards for when hg have services assigned to them.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call flow feature version one now complete.
This feature still needs to consider when entities have service packs assigned such as Call Forward Busy assigned to a Hunt Group. Currently it does not consider this.