Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service_providers_trunk_group_call_capacity method #37

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

LivCurtis
Copy link
Contributor

Added a method to put.py. This was used in Enterprise.py of the eva-builder repo under the increaseCallCapacity method.

Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your missing the docstring in the method which tells people how the method works. Once this is complete it will be all good!

Added doc strings for service_providers_trunk_group_call_capacirty method
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! You missed the type definition in of burtsing_max_active_calls in your docstring it needs the '(int)'

Updated doc string to include '(int)'
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!! Thank you.

@Jordan-Prescott Jordan-Prescott merged commit 0898988 into main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants