Eva bulider methods #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added group_device method to post.py
Added the group_trunk_groups_call_capacity method to put.py under #TRUNK GROUPS
Added group_hunt_group method to post.py
Added group_trunk_group to post.py and group_trunk_group to put.py
Added user_call_processing_policy method
Made changes following JP's review: - Added payload as an argument to group_device and group_hunt_group - Added agents as an argument to group_hunt_group which will assign users to the group
Changed "userID" to be "userId" Updated the Return in the docstring
Updated the group_trunk_group method in post.py to have payload, sip_authentication_username and sip_authentication_password as arguments
Corrected group_trunk_groups_call_capacity and _group_trunk_group methods in put.py. Replaced max_active_calls argument with updates
Added a Return to the doc string of service_prvoiders_trunk_group_call_capacity method in put.py
Updated the method to take a dictionary argument so that it can be used when only one of the fields needs to be updated.
Updated the return of the group_device method in post.py
Corrected some of the eva-builder methods in put.py and post.py. Updated the Returns to state they they return Dicts
Jordan-Prescott
requested changes
Jun 24, 2024
Jordan-Prescott
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods added to put.py:
service_providers_trunk_group_call_capacity
group_device
group_trunk_groups_call_capacity
user_call_processing_policy
group_trunk_group
Methods added to post.py:
group_hunt_group
group_trunk_group