56 modify the way parameters are sent to the api so the values are html encoded #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s using format_filter
- Params dict in all where needed - Format filter updated to return only value - f string removed from all methods
…-api-so-the-values-are-html-encoded
dan-writes-code
approved these changes
Jul 9, 2024
Jordan-Prescott
deleted the
56-modify-the-way-parameters-are-sent-to-the-api-so-the-values-are-html-encoded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters where being tacked onto a f string instead of using the params parameter in the requests module. This would cause issues when parameter values had special characters in them especially '&' as this would cause the server to treat as another parameter.
A params dict has been introduced to each method that needs it and Requester to pass to requests module which will correctly configure this.
Additonal changes added are below: