Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns empty dict if user or group doesnt have license #78

Merged

Conversation

malkin0xb8
Copy link
Collaborator

Decided to make it return and empty dict instead of exception as long scripts that collect all users will be easily filterable instead of just forcing the script to stop.

Added License Exception into exceptions.py for future use case

@malkin0xb8 malkin0xb8 linked an issue Jul 25, 2024 that may be closed by this pull request
@malkin0xb8 malkin0xb8 self-assigned this Jul 25, 2024
@malkin0xb8 malkin0xb8 added the bug Something isn't working label Jul 25, 2024
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comments

odins_spear/methods/get.py Outdated Show resolved Hide resolved
odins_spear/methods/get.py Show resolved Hide resolved
odins_spear/methods/get.py Outdated Show resolved Hide resolved
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is something we will need more in the solution so its good to spot this now and have a solution.

@malkin0xb8 malkin0xb8 merged commit 3e8787c into main Aug 14, 2024
@malkin0xb8 malkin0xb8 deleted the 55-api-raises-400-if-user-license-is-nonexistentwrong branch August 14, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

API Raises 400 if user license is nonexistent/wrong
2 participants