Fixed put.group_hunt_group method #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned an empty dict to "serviceInstanceProfile" as this needs to exist for the method to work. Also corrected a couple of things in the docstring.
odins_spear/methods/put.py
Outdated
| @@ -897,10 +897,10 @@ def group_hunt_groups_status(self, hunt_group_user_ids: list, status: bool =True | |||
|
|
|||
|
|
|||
| def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_user_id: str, updates: dict): | |||
There was a problem hiding this comment.
Change hunt_group_user_id to service_user_id in these args.
Jordan-Prescott
requested changes
Jul 26, 2024
odins_spear/methods/put.py
Outdated
| @@ -913,7 +913,8 @@ def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_u | |||
|
|
|||
| updates["serviceProviderId"] = service_provider_id | |||
| updates["groupId"] = group_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
There was a problem hiding this comment.
Should match new argument
odins_spear/methods/put.py
Outdated
| @@ -913,7 +913,8 @@ def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_u | |||
|
|
|||
| updates["serviceProviderId"] = service_provider_id | |||
| updates["groupId"] = group_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceInstanceProfile"] = {} | |||
There was a problem hiding this comment.
Check if this is in the updates otherwise here you will override it
Changed name of argument from 'hunt_group_user_id' to be 'service_user_id'
Updated group_hunt_group method to add a check if "serviceInstanceProfile" is given in the updates dict before overwriting it with an empty dict
LivCurtis
commented
Jul 26, 2024
odins_spear/methods/put.py
Outdated
| @@ -897,10 +897,10 @@ def group_hunt_groups_status(self, hunt_group_user_ids: list, status: bool =True | |||
|
|
|||
|
|
|||
| def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_user_id: str, updates: dict): | |||
odins_spear/methods/put.py
Outdated
| @@ -913,7 +913,8 @@ def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_u | |||
|
|
|||
| updates["serviceProviderId"] = service_provider_id | |||
| updates["groupId"] = group_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
odins_spear/methods/put.py
Outdated
| @@ -913,7 +913,8 @@ def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_u | |||
|
|
|||
| updates["serviceProviderId"] = service_provider_id | |||
| updates["groupId"] = group_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceInstanceProfile"] = {} | |||
Updated if statement to be 'if not...' rather than 'if ... is None'
Jordan-Prescott
approved these changes
Aug 12, 2024
odins_spear/methods/put.py
Outdated
| @@ -913,19 +913,21 @@ def group_hunt_group(self, service_provider_id: str, group_id: str, hunt_group_u | |||
|
|
|||
| updates["serviceProviderId"] = service_provider_id | |||
| updates["groupId"] = group_id | |||
| updates["serviceUserId"] = hunt_group_user_id | |||
| updates["serviceUserId"] = service_user_id | |||
| if updates.get("serviceInstanceProfile") is None: | |||
There was a problem hiding this comment.
Here you can remove the 'is None' and add 'not'.
Explanation: In Python the If statement can be shortened to look at Boolean states, which it classes None as False. Therefore you can write and if statement like 'if not updates.get("serviceInstanceProfile"):' and this will trigger when that get method evaluates to a Boolean false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigned an empty dict to "serviceInstanceProfile" as this needs to exist for the method to work. Also corrected a couple of things in the docstring.