Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignalTrisJs #224

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Add SignalTrisJs #224

merged 2 commits into from
Aug 24, 2020

Conversation

milesfrain
Copy link
Collaborator

@milesfrain milesfrain commented Aug 23, 2020

Demo: https://try.ps.ai/?github=milesfrain/purescript-cookbook/tris/recipes/SignalTrisJs/src/Main.purs

@cheery
This is a fun example that I'd like to include in the cookbook. I rewrote this to use the Signals library, which I think works better for games. Let us know if we have your permission to include this in the cookbook and whether you'd like to be credited any differently in the readme. Also feel free to critique the code before it's merged. More reviewers are ideal.

Also, here's a branch that shows a series of more incremental changes, before the major signal rewrite. https://github.com/milesfrain/tris/commits/signal

@cheery
Copy link

cheery commented Aug 23, 2020

I already approved this kind of use on my blog, with the license I pick just recently. You have correctly attributed me and there should be no trouble on that front. Thank you for keeping me involved. I appreciate that.

I find the code itself helpful because you've improved on it. I am also satisfied to the crediting. You are very much welcome to merge this commit.

I'll put an update to the page that the Tris can be found from this cookbook as well.

@JordanMartinez
Copy link
Owner

Thanks all!

@JordanMartinez JordanMartinez merged commit 1d3ede9 into JordanMartinez:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants