Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Update pnpm/action-setup to version 3 #1487

Closed
3 tasks done
rubiesonthesky opened this issue Mar 30, 2024 · 2 comments · Fixed by #1477
Closed
3 tasks done

🛠 Tooling: Update pnpm/action-setup to version 3 #1487

rubiesonthesky opened this issue Mar 30, 2024 · 2 comments · Fixed by #1477
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@rubiesonthesky
Copy link
Collaborator

rubiesonthesky commented Mar 30, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Version 3 will use Node 20 to run actions https://github.com/pnpm/action-setup/releases . I noticed that the Github pipelines are complaining about this:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Additional Info

No response
@rubiesonthesky rubiesonthesky added area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏 labels Mar 30, 2024
@rubiesonthesky rubiesonthesky mentioned this issue Mar 30, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @rubiesonthesky for tool.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Mar 30, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @rubiesonthesky! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

rubiesonthesky pushed a commit that referenced this issue Mar 30, 2024
@allcontributors
docs: add rubiesonthesky as a contributor for tool (#1488)
3b23b4b 
Adds @rubiesonthesky as a contributor for tool.

This was requested by JoshuaKGoldberg [in this
comment](#1487 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
JoshuaKGoldberg pushed a commit that referenced this issue Mar 30, 2024
@rubiesonthesky
fix(deps): update pnpm/action-setup@v3 (#1477)
964a9ac 
<!-- 👋 Hi, thanks for sending a PR to TypeStat! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1487 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/TypeStat/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/TypeStat/blob/main/.github/CONTRIBUTING.md)
were taken 🐶

## Overview

<!-- Description of what is changed and how the code change does that.
-->

~~I'm trying to see, will this fix inconsistency between local and CI
lint run~~

This just updates the action version. The inconsistency was because of
unrelated reason, see #1478

Co-authored-by: rubiesonthesky <rubiesonthesky>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): update pnpm/action-setup@v3 rubiesonthesky/TypeStat
2 participants
@rubiesonthesky @JoshuaKGoldberg