Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add BigInt to type aliases #1513

Merged

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

Fixes missing bigint types (finally) 🎉

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.62%. Comparing base (e484ffc) to head (0355e63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1513   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files         175      175           
  Lines       10957    10959    +2     
  Branches     1021     1021           
=======================================
+ Hits         8615     8617    +2     
  Misses       2338     2338           
  Partials        4        4           
Flag Coverage Δ
mutation 73.25% <100.00%> (+<0.01%) ⬆️
unit 28.38% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit 48efbfb into JoshuaKGoldberg:main Apr 9, 2024
11 checks passed
@rubiesonthesky rubiesonthesky deleted the fix-bigint-issue branch January 3, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: bigint is not added to types when adding missing types
2 participants